-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: do not build MPP plan for scan with virtual columns (#23980) #24058
planner: do not build MPP plan for scan with virtual columns (#23980) #24058
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@eurekaka you're already a collaborator in bot's repo. |
/run-integration-compatibility-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 5b28dfe
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #23980 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24058
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23886
Problem Summary:
Planner reports resolve index failure for MPP plan on virtual columns.
What is changed and how it works?
What's Changed:
Avoid generating MPP plan when the scan contains virtual columns.
How it Works:
If we enable MPP plan for such kind of cases, we need to add an extra projection node above to prune the newly appended columns, as what we do for
copTask
, otherwise we would get wrong query results. However, for a MPP task, we may attach plan nodes such as projection, hash aggregation and hash join upon the scan node, which would change the schema of the plan tree, so we have no idea of the target schema that the plan tree should be projected to then. UnlikecopTask
in which thePhysicalTableReader
is the counterpart ofDataSource
, so we can add the projection upon thePhysicalTableReader
, while inmppTask
, thePhysicalTableReader
is acting more like a data receiver, instead of the counterpart of theDataSource
.Meanwhile, I am not sure whether MPP execution engine can handle plan snippets which contain virtual columns, since I noticed that in
addPushedDownSelectionToMppTask
, no MPP task would be produced if the pushed down filter contains virtual columns.Related changes
Check List
Tests
Side effects
N/A
Release note