-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: skip reading mysql.stats_histograms if cached stats is up-to-date (#24175) #24317
statistics: skip reading mysql.stats_histograms if cached stats is up-to-date (#24175) #24317
Conversation
/run-all-tests |
@eurekaka you're already a collaborator in bot's repo. |
dcc09af
to
e30bebe
Compare
/lgtm |
@crazycs520: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e30bebe6a74dc1648f5957ddd118958ec293c537
|
Signed-off-by: ti-srebot <[email protected]>
70f7884
to
9ca407e
Compare
/merge |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #24175 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/24317
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #24096
Problem Summary:
There is no write in the cluster, while mysql.stats_histograms is repeatedly read.
What is changed and how it works?
What's Changed:
Skip reading
mysql.stats_histograms
if the cached stats is up-to-date.Related changes
N/A
Check List
Tests
Side effects
N/A
Release note