planner: fix column pruning bug for Apply and Join

[guo-shaoge]

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #23887

Problem Summary:

Hash Join (eq("abc", tbl1.col1))
  |                     |
Projection     DataSource(tbl1)
  |
Index Join

1. We prune all columns in Projection
2. Resolve indices for col1, Its index is 0(because Projection's output columns are all pruned)
3. Projection is eliminated, because its output columns are all pruned. But Index Join still has output columns
4. Got panic when calc eq("abc", tbl1.col1). Because use index 0 to eval tbl1.col1

Apply also has this problem. So here I also fix this for Apply.

    Apply
     |       |
    DS   Projection
             |
            xxx

What is changed and how it works?

What's Changed: For LogicalJoin and LogicalApply, if they have Projection child, we donot prune all columns in Projection. If Projection is pruned to empty, we make it a Projection 1 (just like count(1))

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Integration test: TestIssue23887

Side effects:

1. Some plan may changes(For situations that Apply/Join's children Projection is empty)
2. For above situations, the performance may change, because we project 1 in runtime.

Release note

• planner: fix column pruning bug for Apply and Join

[guo-shaoge]

/run-all-tests

[guo-shaoge]

This is the second try to fix #23887. Compared with last fix, the scope of influence of this fix is smaller. Only Apply and Join's behaviors are changed.

So other operators like Agg will not be affected (still can push down to TiKV, see here.

[lzmhhh123]

Suggested change

	func addConstOneForEmptyProjection(p LogicalPlan) (err error) {
	func addConstOneForEmptyProjection(p LogicalPlan) {

[guo-shaoge]

done

[guo-shaoge]

@eurekaka @winoros PTAL

[guo-shaoge]

/run-all-tests

[guo-shaoge]

/run-mybatis-test
/run-tics-test

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lzmhhh123
• winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

[lzmhhh123]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: eac8a25

[guo-shaoge]

/run-unit-test

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
12.3% Duplication

[guo-shaoge]

/run-cherry-picker

[ti-srebot]

cherry pick to release-5.0 in PR #24437