Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*/backoff: make backoff type as string instead of interface fmt.Stringer #24810

Merged
merged 4 commits into from
May 25, 2021
Merged

*/backoff: make backoff type as string instead of interface fmt.Stringer #24810

merged 4 commits into from
May 25, 2021

Conversation

AndreMouche
Copy link
Contributor

Signed-off-by: AndreMouche

What problem does this PR solve?

This PR makes backoff type returned Backoffer.GetTypes to the string instead of the interface fmt.Stringer

Part of #22513

Check List

Tests

  • Unit test

Release note

  • No release note

@AndreMouche AndreMouche requested a review from a team as a code owner May 21, 2021 03:36
@AndreMouche AndreMouche requested review from wshwsh12 and removed request for a team May 21, 2021 03:36
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 21, 2021
@AndreMouche AndreMouche added the sig/transaction SIG:Transaction label May 21, 2021
@github-actions github-actions bot added the sig/execution SIG execution label May 21, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2021
@AndreMouche AndreMouche removed sig/execution SIG execution sig/transaction SIG:Transaction labels May 25, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2021
@github-actions github-actions bot added the sig/execution SIG execution label May 25, 2021
@AndreMouche
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 79fd80d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2021
@ti-chi-bot ti-chi-bot merged commit 8c25a00 into pingcap:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

@sticnarf sticnarf Awaiting requested review from sticnarf

Assignees
No one assigned
Labels
sig/execution SIG execution size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndreMouche @ti-chi-bot @disksing @youjiali1995