refactor builtin #250
Merged
refactor builtin #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
| // ExprAggDone is the key indicating that aggregate function is done. | ||
| ExprAggDone = "$aggDone" | ||
| // ExprEvalArgAggEmpty is the key to evaluate the aggregate function for empty table. | ||
| ExprEvalArgAggEmpty = "$agg0" |
There was a problem hiding this comment.
$agg0 is not good, rename another value?
There was a problem hiding this comment.
It is the old code, change it in another PR if possible.
| @@ -123,14 +126,38 @@ func (c *Call) Eval(ctx context.Context, args map[interface{}]interface{}) (v in | |||
| a[i] = v | |||
| } | |||
|
|
|||
| c.createDistinct() | |||
|
PTAL @qiuyesuifeng |
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
CabinfeverB
pushed a commit
to CabinfeverB/tidb
that referenced
this pull request
Mar 15, 2023
…p#250) close pingcap#41485 Co-authored-by: Yexiang Zhang <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: zzm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move builtin function into builtin package