Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Revert tidb_allow_mpp modification for downgrade compatibility and add warnings for enforce mpp. (#25302) #25358

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 11, 2021

cherry-pick #25302 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25358

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25358:release-5.0-1f0245a82142

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1905

Problem Summary: #24516 will let TiDB can't downgrade in some cases.

What is changed and how it works?

Proposal: Enofrce MPP

What's Changed: This PR reverted #24516, introduce a new variable tidb_enforce_mpp and some warning.

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Revert

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot ti-srebot requested review from a team as code owners June 11, 2021 04:18
@ti-srebot ti-srebot requested review from qw4990 and removed request for a team June 11, 2021 04:18
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@LittleFall you're already a collaborator in bot's repo.

@LittleFall
Copy link
Contributor

seems no need to cherry-pick to 5.0? @hanfei1991

@lzmhhh123 lzmhhh123 removed their request for review June 15, 2021 05:52
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qw4990 qw4990 requested review from lzmhhh123 and removed request for qw4990 June 23, 2021 03:40
@lzmhhh123 lzmhhh123 removed their request for review June 28, 2021 02:39
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 30, 2021
@LittleFall
Copy link
Contributor

has been cherry-picked correctly in #26382

@LittleFall LittleFall closed this Sep 2, 2021
@LittleFall LittleFall deleted the release-5.0-1f0245a82142 branch September 2, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants