-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Revert tidb_allow_mpp
modification for downgrade compatibility and add warnings for enforce mpp. (#25302)
#25358
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@LittleFall you're already a collaborator in bot's repo. |
seems no need to cherry-pick to 5.0? @hanfei1991 |
@ti-srebot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
has been cherry-picked correctly in #26382 |
cherry-pick #25302 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25358
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close pingcap/tiflash#1905
Problem Summary: #24516 will let TiDB can't downgrade in some cases.
What is changed and how it works?
Proposal: Enofrce MPP
What's Changed: This PR reverted #24516, introduce a new variable
tidb_enforce_mpp
and some warning.How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note