config, session: make Local Transaction not to affect Stale Read #25559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
do-not-merge/work-in-progress
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
add_enable_local_txn_config
branch
from
0dfd2aa
to
07e0b8a
Compare
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
removed
the
do-not-merge/work-in-progress
nolouch
changed the title
EnableLocalTxn config
nolouch
reviewed
Jun 18, 2021
Signed-off-by: JmPotato <[email protected]>
Yisaer
reviewed
Jun 18, 2021
Signed-off-by: JmPotato <[email protected]>
ti-chi-bot
added
size/M
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
add_enable_local_txn_config
branch
from
4a9e53e
to
f77861d
Compare
|
/label needs-cherry-pick-5.1 |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 45bd6b6c9191356d5673d4f85807aa3e261b04d8
|
ti-chi-bot
added
status/can-merge
|
/merge cancel |
|
/hold |
ti-chi-bot
added
the
do-not-merge/hold
Signed-off-by: JmPotato <[email protected]>
JmPotato
force-pushed
the
add_enable_local_txn_config
branch
from
7aabb96
to
93b11f6
Compare
|
/unhold |
ti-chi-bot
removed
the
do-not-merge/hold
Yisaer
reviewed
Jun 22, 2021
Signed-off-by: JmPotato <[email protected]>
Yisaer
approved these changes
Jun 22, 2021
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 1d31761
|
ti-chi-bot
added
the
status/can-merge
|
/merge |
|
@JmPotato: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
|
/run-check_dev_2 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 22, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-5.1 in PR #25668 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
Close #25479.
Decouple Stale Read and Local Txn by adding a new system variable named
EnableLocalTxn. Should merge after #25525.What is changed and how it works?
Because both Stale Read and Local Txn need the
zonelabel to determine their behavior, however, the latter is not released yet, to make sure they will not bother each other. I add a system variableEnableLocalTxnto disable Local Txn.Related changes
GetTxnScopeFromConfigreturnTxnScopefrom config directly tikv/client-go#93Check List
Tests
Release note
No release note.