Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check filter condition in func convertToPartialTableScan (#25294) #25593

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 21, 2021

cherry-pick #25294 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25593

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25593:release-5.1-efc774aa5f97

What problem does this PR solve?

Issue Number: close #25045

Problem Summary:

Cannot find column while use index merge

What is changed and how it works?

What's Changed:

  • Change logic in func convertToPartialTableScan.

How it Works:

  • Remove ineffective filter conditions in func convertToPartialTableScan to prevent use column out of the schema of PhysicalTableScan.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • N/A

Release note

  • planner: check filter condition in func convertToPartialTableScan

@ti-srebot ti-srebot requested review from a team as code owners June 21, 2021 03:01
@ti-srebot ti-srebot requested review from wshwsh12 and hanfei1991 and removed request for a team June 21, 2021 03:01
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@rebelice you're already a collaborator in bot's repo.

@wshwsh12 wshwsh12 removed their request for review June 21, 2021 03:18
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 21, 2021
@zhouqiang-cl zhouqiang-cl added backport-5.1.0 cherry-pick-approved Cherry pick PR approved by release team. labels Jun 21, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1f314c2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 21, 2021
@qw4990
Copy link
Contributor

qw4990 commented Jun 21, 2021

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit cb42353 into pingcap:release-5.1 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants