Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix wrong resource tag of transaction commit statement #25616

Merged
merged 5 commits into from
Jun 23, 2021
Merged

*: fix wrong resource tag of transaction commit statement #25616

merged 5 commits into from
Jun 23, 2021

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Related PR: #24854

This PR fix wrong resource tag of transaction commit statement.

Related changes

  • N/A

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • N/A

Release note

  • No release note.

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 21, 2021
@crazycs520
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 21, 2021
@crazycs520
Copy link
Contributor Author

Merge #25617 first.

jackysp
jackysp approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 22, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 22, 2021
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 80d2f7a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2021
@zhouqiang-cl
Copy link
Contributor

/run-check_dev

@zhouqiang-cl
Copy link
Contributor

/run-check_dev_2

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit ddfc0bd into pingcap:master Jun 23, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 23, 2021
@crazycs520 @ti-srebot
cherry pick pingcap#25616 to release-5.1
4e85d15 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jun 23, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25706

ti-chi-bot pushed a commit that referenced this pull request Jul 20, 2021
@ti-srebot
*: fix wrong resource tag of transaction commit statement (#25616) (#…
8e6c2e0 
…25706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.1 sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crazycs520 @ti-chi-bot @zhouqiang-cl @ti-srebot @jackysp @wjhuang2016