executor: reject setting read ts to a future time (#25732) #25762
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #25732 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25762
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #25680
What is changed and how it works?
This PR checks the read ts in two cases:
tidb_snapshot
system variableIt first checks with latest local timestamp (with low cost). If the check fails, it gets a timestamp from PD to do a double check.
Related changes
Check List
Tests
Side effects
Release note