Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/stmtsummary: discard the plan if it is too long and enlarge the tidb_stmt_summary_max_stmt_count value to 3000 (#25843) #25873

Merged
merged 6 commits into from
Aug 12, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 1, 2021

cherry-pick #25843 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25873

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25873:release-5.0-c4424c2920b5

Signed-off-by: crazycs [email protected]

What problem does this PR solve?

  1. Currently statements_summary doesn't restrict the plan size, in some extreme scenarios, TIDB might OOM. This PR discards the statements_summary plan if it is too long (encode plan size more than 1MB) to avoid occupies too much memory.

  2. Enlarge tidb_stmt_summary_max_stmt_count default value from 200 to 3000. Since 200 is too small when troubleshooting.

What is changed and how it works?

About Enlarge tidb_stmt_summary_max_stmt_count default value, this doc record the test process. The final conclusion is:
Enlarge the tidb_stmt_summary_max_stmt_count default value to 3000:

  • If the SQL size is 1024, cache 3000 statements only consume 55MB, memory.
  • If the SQL size is 10240, cache 3000 statements only consume 200MB memory.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:

Check List

Tests

  • Unit test
  • Manual test

Side effects

  • Performance regression
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Enlarge the variable tidb_stmt_summary_max_stmt_count default value from 200 to 3000

@ti-srebot ti-srebot requested a review from a team as a code owner July 1, 2021 11:13
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team July 1, 2021 11:13
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@crazycs520 you're already a collaborator in bot's repo.

Signed-off-by: crazycs <[email protected]>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2021
@crazycs520
Copy link
Contributor

@djshow832 PTAL

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • djshow832

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2021
@crazycs520
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c0cac7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 12, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/config sig/diagnosis SIG: Diagnosis sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants