Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: support stable result mode (#25971) #26084

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 9, 2021

cherry-pick #25971 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25995

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/25995:release-5.1-c24a90f9e7f5

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: support stable result mode in the planner

What is changed and how it works?

Results of some queries are not stable, for example:

create table t (a int);
insert into t values (1), (2);
select a from t;

In the case above, the result can be 1 2 or 2 1, which is not stable.
This PR introduces a new switch that can make the results of these queries stable.

This feature is implemented as a logical optimization rule, which stabilizes results by modifying Sort in plans or inject new Sort into plans.
First, all operators are divided into 2 types:

  1. input-order keepers: Selection, Projection, Limit;
  2. all other operators.

The basic idea of this rule is:

  1. iterate the plan from the root, and ignore all input-order keepers;
  2. when meeting the first non-input-order keeper,
    2.1. if it's a Sort, complete it by appending its output columns into its order-by list,
    2.2. otherwise, inject a new Sort upon this operator.

Check List

Tests

  • Unit test

Release note

  • planner: support stable result mode

@qw4990 qw4990 requested review from a team as code owners July 9, 2021 08:49
@qw4990 qw4990 requested review from wshwsh12 and XuHuaiyu and removed request for a team July 9, 2021 08:49
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 9, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 9, 2021

/run-all-tests

@github-actions github-actions bot added sig/execution SIG execution sig/sql-infra SIG: SQL Infra labels Jul 9, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 9, 2021

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 9, 2021

/run-all-tests

@wshwsh12 wshwsh12 removed their request for review July 10, 2021 05:05
@XuHuaiyu XuHuaiyu removed their request for review July 12, 2021 02:52
@ti-chi-bot
Copy link
Member

@time-and-fate: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@time-and-fate
Copy link
Member

/sig planner

@ti-chi-bot ti-chi-bot added the sig/planner SIG: Planner label Jul 12, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1926332

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jul 12, 2021

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/execution SIG execution sig/planner SIG: Planner sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants