Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor , store: fix golangci-lint error when make dev #26096

Merged
merged 5 commits into from
Jul 20, 2021

Conversation

hecomlilong
Copy link
Contributor

fix error of unnecessary use of fmt.Sprintf (gosimple) and ineffectual assignment to err (ineffassign)

What problem does this PR solve?

Problem Summary:

What is changed and how it works?

What's Changed:

fmt.Sprintf("select * from t") => "select * from t"
_, cluster, pdClient, err := testutils.NewMockTiKV("", nil) => _, cluster, pdClient, _ := testutils.NewMockTiKV("", nil)

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Tests

  • Unit test

Side effects

  • Performance regression

  • Breaking backward compatibility

Release note

  • No release note

fix error of unnecessary use of fmt.Sprintf (gosimple) and ineffectual assignment to err (ineffassign)
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 9, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Jul 9, 2021
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2021
Copy link
Member

@mmyj mmyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2021
@hecomlilong
Copy link
Contributor Author

/cc @AilinKid
Hi AilinKid,
Would you please review this tiny fix for me?
Appreciate greatly.

@ti-chi-bot ti-chi-bot requested a review from AilinKid July 15, 2021 03:57
@hecomlilong
Copy link
Contributor Author

/cc @AilinKid @AndreMouche @Reminiscent @SunRunAway @Tjianke @TszKitLo40 @XuHuaiyu @Yisaer @b41sh @bb7133 @bobotu @breeswish @cfzjywxk @coocood @crazycs520 @fzhedu @guo-shaoge @hanfei1991 @ichn-hu @imtbkcat @jackysp @js00070 @lysu @lzmhhh123 @pingyu @qw4990 @shenli @shihongzhi @tangenta @tangwz @tiancaiamao @tsthght @winkyao @winoros @wjhuang2016 @wshwsh12 @zimulala @zz-jason
Hi all,
Would you please review this tiny fix for me?
Appreciate greatly.
It's my first time PR, so it has a particular meaning and sorry for this annoying message.

@ti-chi-bot
Copy link
Member

@hecomlilong: GitHub didn't allow me to request PR reviews from the following users: Tjianke, imtbkcat, js00070, pingyu, tsthght, TszKitLo40, b41sh, tangwz, bobotu, shihongzhi.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @AilinKid @AndreMouche @Reminiscent @SunRunAway @Tjianke @TszKitLo40 @XuHuaiyu @Yisaer @b41sh @bb7133 @bobotu @breeswish @cfzjywxk @coocood @crazycs520 @fzhedu @guo-shaoge @hanfei1991 @ichn-hu @imtbkcat @jackysp @js00070 @lysu @lzmhhh123 @pingyu @qw4990 @shenli @shihongzhi @tangenta @tangwz @tiancaiamao @tsthght @winkyao @winoros @wjhuang2016 @wshwsh12 @zimulala @zz-jason
Hi all,
Would you please review this tiny fix for me?
Appreciate greatly.
It's my first time PR, so it has a particular meaning and sorry for this annoying message.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SunRunAway
  • mmyj

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2021
@SunRunAway
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f2115eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 20, 2021
@TszKitLo40
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@hecomlilong: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 029becc into pingcap:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants