-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: reduce NewRuntimeStatsColl() object allocation #26164
*: reduce NewRuntimeStatsColl() object allocation #26164
Conversation
For #25573 |
@xhebox: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9d86160
|
What problem does this PR solve?
Take part of the code from #26007
ResetContextStmt is not touched
What is changed and how it works?
What's Changed:
How it Works:
Change
NewRuntimeStatsColl()
toNewRuntimeStatsColl(*RuntimeStatsColl)
so when the argument is not nil, the object is reused.Check List
Tests
Documentation
Release note