executor: fix goword checker bugs in insert*.go #26257
Conversation
ti-chi-bot
added
the
size/XS
|
/cc @mmyj @ngaut @wjhuang2016 thanks ^-^ |
executor/insert_test.go
Outdated
| @@ -1571,7 +1571,7 @@ func combination(items []string) func() []string { | |||
| } | |||
| } | |||
|
|
|||
| // See https://github.com/pingcap/tidb/issues/24582 | |||
| // TestDuplicatedEntryErr : See https://github.com/pingcap/tidb/issues/24582 | |||
There was a problem hiding this comment.
ok, thanks for reply
zoomxi
force-pushed
the
zoomxi/24044_new
branch
2 times, most recently
from
c2e8140
to
4d7dd3e
Compare
|
Following is the all Is there any issue to track making |
|
I found an issue about it. |
executor/insert_common.go
Outdated
| @@ -75,7 +75,7 @@ type InsertValues struct { | |||
| hasRefCols bool | |||
| hasExtraHandle bool | |||
|
|
|||
| // Fill the autoID lazily to datum. This is used for being compatible with JDBC using getGeneratedKeys(). | |||
| // lazyFillAutoID Fill the autoID lazily to datum. This is used for being compatible with JDBC using getGeneratedKeys(). | |||
There was a problem hiding this comment.
lazyFillAutoID indicates whatever had been filled the autoID lazily to datum. This is used for being...
executor/insert_common.go
Outdated
| @@ -86,7 +86,7 @@ type InsertValues struct { | |||
|
|
|||
| stats *InsertRuntimeStat | |||
|
|
|||
| // LoadData use two goroutines. One for generate batch data, | |||
| // isLoadData LoadData use two goroutines. One for generate batch data, | |||
There was a problem hiding this comment.
isLoadData indicates whatever current goroutine is use for generating batch data. LoadData use two goroutines...
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 58f5def
|
ti-chi-bot
added
the
status/can-merge
|
@zoomxi: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary: according to the discuss in PR #26189 , i make a PR to fix goword checker bugs in insert*.go first, and after this i will make another PR for issue fix.
What is changed and how it works?
What's Changed: executor/insert*.go
How it Works: fix goword checker bugs
Check List
Tests
Release note