-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: fix copr-cache metrics (#26339) #26343
metrics: fix copr-cache metrics (#26339) #26343
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
@jackysp you're already a collaborator in bot's repo. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f23883e
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #26339 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26343
After apply modifications, you can push your change to this PR via:
Signed-off-by: Shuaipeng Yu [email protected]
What problem does this PR solve?
Issue Number: close #26338
Problem Summary:
The metrics formula is wrong on Grafana.
What is changed and how it works?
Proposal: xxx
What's Changed:
Fix it as a counter.
How it Works:
Check List
Tests
The same step in the issue Copr-cache metrics on TiDB have no data #26338 .
Release note