planner: fix the unstable unit test TestTableFromMeta (#26463) #26476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
1 task
ti-srebot
added
size/XS
ti-srebot
requested review from
rebelice,
Reminiscent,
time-and-fate and
winoros
|
@qw4990 you're already a collaborator in bot's repo. |
zhouqiang-cl
added
the
cherry-pick-approved
qw4990
approved these changes
Sep 7, 2021
rebelice
approved these changes
Sep 8, 2021
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 4e9b256
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #26463 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/26476After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #25691
Problem Summary: planner: fix the unstable unit test TestTableFromMeta
What is changed and how it works?
TestTableFromMetamodifies some read-only meta table info, which is incorrect and might be conflicted with the background auto-analyze.This PR makes it clone meta table info before modifying it.
Check List
Tests
Release note
No release note