Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util/timeutil: migrate test-infra to testify #26497

Merged
merged 5 commits into from
Jul 26, 2021
Merged

util/timeutil: migrate test-infra to testify #26497

merged 5 commits into from
Jul 26, 2021

Conversation

top628LJ
Copy link
Contributor

Signed-off-by: top628LJ [email protected]

What problem does this PR solve?

Issue Number: close #26426

What is changed and how it works?

What's Changed: migrate test-infra to testify for util/timeutil

Release note

  • No release note

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @top628LJ!

It looks like this is your first PR to pingcap/tidb 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tidb. 😃

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2021
@top628LJ
Copy link
Contributor Author

/run-all-tests

tisonkun
tisonkun reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Comments inline.

util/timeutil/time_test.go Outdated
tz, err := inferTZNameFromFileName("/usr/share/zoneinfo/Asia/Shanghai")

c.Assert(err, IsNil)
c.Assert(tz, Equals, "Asia/Shanghai")
assert.Nil(t, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert.Nil(t, err)
require.NoError(t, err)

You may use more precious assertions. Also require plays the same as c.Assert which FailNow if assertion failed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it and updated

@top628LJ
Copy link
Contributor Author

/cc @tisonkun @xhebox @tiancaiamao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
tisonkun
tisonkun approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@top628LJ
Copy link
Contributor Author

/cc @tiancaiamao @disksing

@ti-chi-bot ti-chi-bot requested a review from disksing July 24, 2021 02:01
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 26, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 26acb4c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2021
@ti-chi-bot
Copy link
Member

@top628LJ: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@top628LJ
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit 399586e into pingcap:master Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@disksing disksing disksing approved these changes

@xhebox xhebox xhebox approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for util/timeutil pkg
6 participants
@top628LJ @CLAassistant @ti-chi-bot @disksing @xhebox @tisonkun