Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression/expression: add pushdown functions #26786

Merged
merged 21 commits into from
Aug 8, 2021
Merged

expression/expression: add pushdown functions #26786

merged 21 commits into from
Aug 8, 2021

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Aug 2, 2021 •
edited by zanmato1984
Loading

What problem does this PR solve?

Issue Number: close pingcap/tiflash#2334

Problem Summary: add pushdown functions

What is changed and how it works?

What's Changed: add ascii, coalesce, length, position, trim pushdown functions

Check List

Tests

  • Unit test
  • Integration test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2021
@xzhangxian1008
Copy link
Contributor Author

/cc @zanmato1984

@zanmato1984
Copy link
Contributor

Part of pingcap/tiflash#2424

zanmato1984
zanmato1984 approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 6, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2021
windtalker
windtalker approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 6, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2021
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8066266

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2021
@ti-chi-bot ti-chi-bot merged commit 30cf15a into pingcap:master Aug 8, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 8, 2021
@xzhangxian1008 @ti-srebot
cherry pick pingcap#26786 to release-5.0
d9676e8 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 8, 2021
Closed
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #26995

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 8, 2021
@xzhangxian1008 @ti-srebot
cherry pick pingcap#26786 to release-5.1
a0dbb8a 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 8, 2021
Closed
2 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #26996

This was referenced Oct 27, 2021
Merged
Closed
@windtalker windtalker mentioned this pull request Apr 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push down function COALESCE
6 participants
@xzhangxian1008 @ti-chi-bot @zanmato1984 @ti-srebot @windtalker @rebelice