Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM]executor: fix data race in tryFillViewColumnType #26892

Closed
wants to merge 12 commits into from
Closed

[DNM]executor: fix data race in tryFillViewColumnType #26892

wants to merge 12 commits into from

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Aug 4, 2021

What problem does this PR solve?

Issue Number:
close #25691
close #26539
close #25898

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. component/test labels Aug 4, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 4, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Aug 4, 2021
ichn-hu
ichn-hu approved these changes Aug 4, 2021
View reviewed changes
executor/show.go
Comment on lines +1743 to +1744
col = col.Clone()
col.FieldType, tbl.Columns[i] = *(col.FieldType.Clone()), col
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does the change fix the data race?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 4, 2021
@ichn-hu ichn-hu mentioned this pull request Aug 4, 2021
Closed
@zhouqiang-cl
Copy link
Contributor

how about it now😃

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2021
@qw4990
Copy link
Contributor

qw4990 commented Aug 19, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5fec701

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2021
@qw4990
Copy link
Contributor

qw4990 commented Aug 19, 2021

/merge

@ti-chi-bot
Copy link
Member

@XuHuaiyu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@XuHuaiyu XuHuaiyu changed the title executor: fix data race in tryFillViewColumnType [DNM]executor: fix data race in tryFillViewColumnType Aug 20, 2021
@XuHuaiyu
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2021
@zhouqiang-cl zhouqiang-cl removed the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2021
@zhouqiang-cl
Copy link
Contributor

/merge cancel

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: /merge cancel is only allowed for the PR author and the committers in list.

In response to this:

/merge cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@XuHuaiyu XuHuaiyu closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

Assignees
No one assigned
Labels
component/test do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
5 participants
@XuHuaiyu @ti-chi-bot @zhouqiang-cl @qw4990 @ichn-hu