Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix unstable test TestAnalyzeGlobalStatsWithOpts2 #26921

Merged
merged 2 commits into from
Aug 5, 2021
Merged

test: fix unstable test TestAnalyzeGlobalStatsWithOpts2 #26921

merged 2 commits into from
Aug 5, 2021

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented Aug 5, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #24679

Problem Summary:

No logical change, distinguish the table during the test and check the results separately

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 5, 2021
@rebelice rebelice requested a review from qw4990 August 5, 2021 07:20
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Aug 5, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. status/LGT1 Indicates that a PR has LGTM 1. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 5, 2021
@rebelice rebelice changed the title fix unstable test TestAnalyzeGlobalStatsWithOpts2 test: fix unstable test TestAnalyzeGlobalStatsWithOpts2 Aug 5, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Aug 5, 2021

/run-check_title

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 5, 2021
@rebelice
Copy link
Contributor Author

rebelice commented Aug 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15db71e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@ti-chi-bot ti-chi-bot merged commit b974e5f into pingcap:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestAnalyzeGlobalStatsWithOpts2 test failed
5 participants
@rebelice @ti-chi-bot @sre-bot @qw4990 @time-and-fate