-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: Fix compatibility with JDBC and Automatic TLS (#26931) #27013
util: Fix compatibility with JDBC and Automatic TLS (#26931) #27013
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@dveeden you're already a collaborator in bot's repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-build |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e4299d4
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #26931 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/27013
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Set subject in automatically generated TLS certificates to
TiDB_Server_Auto_Generated_Server_Certificate
, which is similar towhat MySQL does.
This fixes this issue when connecting with Connector/J:
policy set to LEGACY.
Test code:
Issue Number: close #26898
Check List
Tests
Release note