-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: Fix lock view cannot show key info correctly for partition table #27027
util: Fix lock view cannot show key info correctly for partition table #27027
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM.
….com/MyonKeminta/tidb into m/fix-lock-view-decode-partition-key
/run-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/merge |
@cfzjywxk: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: edde822
|
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #27035 |
What problem does this PR solve?
Problem Summary: Currently when using the
data_lock_waits
anddeadlocks
table of lock view, if it shows a key from a partitioned table, thekey_info
column may not show the key's information correctly. It's because Lock View didn't handle these kind of keys correctly. This PR fixes this problem.What is changed and how it works?
Proposal: xxx
What's Changed: In
util/keydecoder
, which is specifically used by Lock View for finding information from keys: When failed to find a table by table ID, try to use it as a partition ID and try to find the partition info and its corresponding table info.Check List
Tests
Side effects
Documentation
Release note