Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: correctly set StatsVersion of tablePlan in copTask #27161

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

xuyifangreeneyes
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #27083

Problem Summary:
Explain results show stats:pseudo in operator info though it uses true stats.

What is changed and how it works?

When copTask.tablePlan is first created, we set its stats as empty StatsInfo with correct StatsVersion. We don't set StatsInfo directly because it depends on copTask.indexPlan and copTask.indexPlan may change later. In (*copTask).finishIndexPlan, when we assign copTask.indexPlan's stats to copTask.tablePlan, we keep StatsVersion unchanged.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2021
@xuyifangreeneyes
Copy link
Contributor Author

/cc @winoros

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2021
@xuyifangreeneyes
Copy link
Contributor Author

/cc @Reminiscent @time-and-fate

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 25, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 25, 2021
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 86c6e9a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 25, 2021
@xuyifangreeneyes
Copy link
Contributor Author

/run-all-tests

@xuyifangreeneyes
Copy link
Contributor Author

/run-all-tests

@winoros
Copy link
Member

winoros commented Aug 25, 2021

/merge

1 similar comment
@winoros
Copy link
Member

winoros commented Aug 25, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 9e248d9 into pingcap:master Aug 25, 2021
@xuyifangreeneyes xuyifangreeneyes deleted the fix-issue-27083 branch October 30, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explain results show stats:pseudo in operator info though it uses true stats
4 participants