-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Log SQL statement when coprocessor encounteres lock (#27735) #27924
*: Log SQL statement when coprocessor encounteres lock (#27735) #27924
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@MyonKeminta you're already a collaborator in bot's repo. |
Signed-off-by: ti-srebot <[email protected]>
2c7cab2
to
aa43a78
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: aa43a78
|
/merge |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
cherry-pick #27735 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/27924
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #27718
Problem Summary: The debug log on coprocessor encounters lock doesn't print out the statement, which makes it difficult to know what statement was affected by the lock. This PR tries to add the log.
What is changed and how it works?
What's Changed: Added a callback parameter to the
Send
method ofkv.Client
that accepts a new TransactionEvent object. This avoids to pass the SQL statement deep down to the coprocessor client part. And I think this callback and events can also be reused by Lock View.How it Works:
Check List
Tests
Side effects
Documentation
Release note