copr: avoid NPE when store is not available when balance batch cop task (#28110)

[ti-srebot]

cherry-pick #28110 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/28139

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/28139:release-5.1-c6dfd705e11a

---

What problem does this PR solve?

Issue Number: close #28096

Problem Summary:
As described in the issue.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:
The root cause is in L162, it tries to get err.Error() even if err is nil

tidb/store/copr/batch_coprocessor.go

Lines 161 to 167 in b839744

	if err != nil || !resp.Resp.(*mpp.IsAliveResponse).Available {
	logutil.BgLogger().Warn("Cannot detect store's availability", zap.String("store address", s.GetAddr()), zap.String("err message", err.Error()))
	mu.Lock()
	mppStoreLastFailTime[s.GetAddr()] = time.Now()
	mu.Unlock()
	return
	}

The pr fix it by only get err.Error() if err is not nil.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix a bug that TiDB may crash when TiFlash is shutting down.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• fzhedu
• qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[ti-srebot]

/run-all-tests

[ti-srebot]

@windtalker you're already a collaborator in bot's repo.

[fzhedu]

/LGTM

[fzhedu]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 3c355ee

[ti-chi-bot]

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.