Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: proposal for reducing data inconsistencies #28271

Merged
merged 13 commits into from
Mar 17, 2022
Merged

docs: proposal for reducing data inconsistencies #28271

merged 13 commits into from
Mar 17, 2022

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Sep 22, 2021 •
edited
Loading

Signed-off-by: ekexium [email protected]

Issue Number: ref #26833

What problem does this PR solve?

Add an proposal the reduce data inconsistencies.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • MyonKeminta
  • cfzjywxk

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2021
cfzjywxk
cfzjywxk approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2021
@morgo
Copy link
Contributor

morgo commented Sep 23, 2021

LGTM (non binding; I don't know this area of the code)

@ekexium
fix typo
0442579 
Signed-off-by: ekexium <[email protected]>
@ekexium ekexium mentioned this pull request Dec 9, 2021
Merged
14 tasks
@ekexium
Copy link
Contributor Author

ekexium commented Jan 19, 2022

PTAL @MyonKeminta

MyonKeminta
MyonKeminta reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be you can also add some description about the new system variables and their default behavior in both new clusters and updated clusters.

docs/design/2021-09-22-data-consistency.md Outdated Show resolved Hide resolved
docs/design/2021-09-22-data-consistency.md Outdated Show resolved Hide resolved
docs/design/2021-09-22-data-consistency.md Outdated Show resolved Hide resolved
@ekexium
update content
a39448c 
Signed-off-by: ekexium <[email protected]>
MyonKeminta
MyonKeminta reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

docs/design/2021-09-22-data-consistency.md Outdated Show resolved Hide resolved
@ekexium
capitalize list items
2c0c0eb 
Signed-off-by: ekexium <[email protected]>
@ekexium
Copy link
Contributor Author

ekexium commented Mar 7, 2022

PTAL @MyonKeminta

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 9, 2022
@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2c0c0eb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7120b38ea0637f15e58b3a04c2d01704825aeaa2

@cfzjywxk
Copy link
Contributor

/merge

@hawkingrei
Copy link
Member

/run-unit-test

1 similar comment
@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 40d049d into pingcap:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo left review comments

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

@lysu lysu Awaiting requested review from lysu

Assignees

@MyonKeminta MyonKeminta

Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ekexium @ti-chi-bot @morgo @youjiali1995 @sre-bot @cfzjywxk @hawkingrei @MyonKeminta