Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix auto analyze triggered out of specified time #28703

Merged
merged 2 commits into from
Oct 11, 2021
Merged

statistics: fix auto analyze triggered out of specified time #28703

merged 2 commits into from
Oct 11, 2021

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #28698

Problem Summary:

As the title stated.

What is changed and how it works?

All kinds of auto analyze should check the time before being executed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

fix auto analyze may get triggered out of specified time.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2021
@time-and-fate
Copy link
Member Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/label needs-cherry-pick-5.1
/label needs-cherry-pick-5.2

@time-and-fate
Copy link
Member Author

/component statistics

@qw4990 qw4990 added the sig/planner SIG: Planner label Oct 11, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 11, 2021
@qw4990
Copy link
Contributor

qw4990 commented Oct 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b846ee

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 11, 2021
@ti-chi-bot ti-chi-bot merged commit 9f094cc into pingcap:master Oct 11, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 11, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#28703 to release-4.0
0a74e2b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 11, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #28719

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 11, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#28703 to release-5.0
60e87d9 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 11, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #28721

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 11, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#28703 to release-5.1
e0e4c3e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 11, 2021
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #28723

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 11, 2021
@time-and-fate @ti-srebot
cherry pick pingcap#28703 to release-5.2
5e07682 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Oct 11, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28725

time-and-fate added a commit to time-and-fate/tidb that referenced this pull request Oct 12, 2021
@time-and-fate
statistics: fix auto analyze triggered out of specified time (pingcap…
5d54f66 
…#28703)
@time-and-fate time-and-fate mentioned this pull request Oct 12, 2021
Merged
12 tasks
zhouqiang-cl added a commit that referenced this pull request Oct 12, 2021
@time-and-fate @zhouqiang-cl
statistics: fix auto analyze triggered out of specified time (#28703) (…
18d6031 
…#28758)

* statistics: fix auto analyze triggered out of specified time (#28703)


Co-authored-by: zhouqiang <[email protected]>
ti-chi-bot pushed a commit that referenced this pull request Oct 14, 2021
@ti-srebot
statistics: fix auto analyze triggered out of specified time (#28703) (…
2450f35 
…#28725)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/statistics needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto analyze may get triggered out of specified time when new index is added
5 participants
@time-and-fate @ti-chi-bot @qw4990 @ti-srebot @winoros