-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table, parser: check for invalid GBK characters before insertion #28814
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/lgtm cancel |
@tangenta Is this ready to review? |
Blocked by #29736. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 74f1b49
|
/hold |
test is failed |
@xiongjiwei The test is confirmed to be unstable. /unhold |
/merge |
What problem does this PR solve?
Issue Number: close #28778.
Problem Summary:
À
is not a valid GBK character, TiDB should report an "incorrect string value" error.What is changed and how it works?
Add
IsValid
function forEncoding
.Check List
Tests
Side effects
Documentation
Release note