Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table, parser: check for invalid GBK characters before insertion #28814

Merged
merged 25 commits into from
Nov 22, 2021

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #28778.

Problem Summary:

À is not a valid GBK character, TiDB should report an "incorrect string value" error.

mysql> create table t (a varchar(255) charset gbk);
Query OK, 0 rows affected (0.04 sec)
mysql> insert into t values ('À');
Query OK, 1 row affected

What is changed and how it works?

Add IsValid function for Encoding.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xiongjiwei
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 14, 2021
table/column.go Outdated Show resolved Hide resolved
table/column.go Show resolved Hide resolved
parser/charset/encoding.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 21, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 2, 2021
@xiongjiwei
Copy link
Contributor

/lgtm cancel

@zimulala
Copy link
Contributor

zimulala commented Nov 9, 2021

@tangenta Is this ready to review?

@tangenta
Copy link
Contributor Author

Blocked by #29736.

parser/charset/encoding_table.go Show resolved Hide resolved
parser/charset/encoding_table.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 19, 2021
parser/charset/encoding_table.go Show resolved Hide resolved
parser/charset/encoding_table.go Outdated Show resolved Hide resolved
parser/charset/encoding_table.go Outdated Show resolved Hide resolved
parser/charset/encoding_table.go Outdated Show resolved Hide resolved
@xiongjiwei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74f1b49

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2021
@xiongjiwei
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2021
@xiongjiwei
Copy link
Contributor

/hold

test is failed

@tangenta
Copy link
Contributor Author

@xiongjiwei The test is confirmed to be unstable.

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2021
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit c835349 into pingcap:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for invalid GBK characters before insertion
4 participants