-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: Fix wrong result of hour function in vectorized expression (#28857) #28870
expression: Fix wrong result of hour function in vectorized expression (#28857) #28870
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@wshwsh12 you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7f12627
|
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1a4a7c7
|
cherry-pick #28857 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/28870
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #28643
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
We should use
types.Duration.Hour()
to get hour, nottime.Duration.Hours()
in golang library.types.Duration.Hour()
will extract the hour and ignore whether the duration is negative.How it Works:
Check List
Tests
Side effects
Documentation
Release note