-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: support the 'alter table xx cache' and 'alter table xx nocache' #28922
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Welcome @jayl-zxl! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test to cover the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
lgtm |
already remove it |
@tiancaiamao @jayl-zxl I think the issue deserve a release note? |
Does |
@tiancaiamao This operation is not supported for the time being |
I've change the release note description for this PR. |
@djshow832 PTAL |
@tiancaiamao we should follow a format of release-note to pass the tide checker...updated. |
okay already modify it |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1311d01
|
@jayl-zxl: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Support
alter table ${table_name} cache or nocache
, close #28926See Optimizing hotspot small tables #25293
Problem Summary:
What is changed and how it works?
There is no similar syntax in mysql, so we used an operation similar to oracle syntax. see : oracle documentation It will not affect the existing sql syntax.
How it Works:
ALTER TABLE xxx cache(CACHE)
it turns a non-cache table into a cache tableALTER TABLE xxx nocache(NOCACHE)
it turns a cache table into a non-cache tableCheck List
Tests
Release note