Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: adjust initialization sequence of domain-reload and ddl-start to avoid infoCache nil #28945

Merged
merged 10 commits into from
Oct 21, 2021
Merged

domain: adjust initialization sequence of domain-reload and ddl-start to avoid infoCache nil #28945

merged 10 commits into from
Oct 21, 2021

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Oct 19, 2021 •
edited
Loading

Signed-off-by: ailinkid [email protected]

What problem does this PR solve?

Issue Number: close #28948

What is changed and how it works?

What's Changed:
domain: adjust Initialization sequence of domain-reload and ddl-start to avoid infoCache nil

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
reproduce the step described in the issue again, make sure the panic won't happen again.

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • wjhuang2016
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2021
@AilinKid AilinKid added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2021
@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
fmt
f90e8a9 
Signed-off-by: ailinkid <[email protected]>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 19, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2021
@AilinKid
.
2413385 
Signed-off-by: ailinkid <[email protected]>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2021
@AilinKid AilinKid changed the title domain: adjust Initialization sequence of domain-reload and ddl-start to avoid infoCache nil domain: adjust initialization sequence of domain-reload and ddl-start to avoid infoCache nil Oct 19, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2021
@AilinKid
.
3770849 
Signed-off-by: ailinkid <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 19, 2021
@AilinKid
Copy link
Contributor Author

/run-all-tests

@AilinKid
Copy link
Contributor Author

/build

zimulala
zimulala approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2021
@xhebox
Copy link
Contributor

xhebox commented Oct 21, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: adf3b4f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2021
@ti-chi-bot
Copy link
Member

@AilinKid: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AilinKid
Copy link
Contributor Author

/merge

@ti-chi-bot ti-chi-bot merged commit 6219010 into pingcap:master Oct 21, 2021
@xuyifangreeneyes xuyifangreeneyes mentioned this pull request Mar 29, 2022
Merged
12 tasks
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@xhebox xhebox xhebox approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

restart tidb will get stuck in panic with internal SQL execution in delete_range
5 participants
@AilinKid @ti-chi-bot @xhebox @zimulala @wjhuang2016