server: let plan replayer support forward request #29299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/work-in-progress
Signed-off-by: yisaer <[email protected]> add log Signed-off-by: yisaer <[email protected]> add log Signed-off-by: yisaer <[email protected]> add log Signed-off-by: yisaer <[email protected]> add log Signed-off-by: yisaer <[email protected]> fix get topo Signed-off-by: yisaer <[email protected]> revise log Signed-off-by: yisaer <[email protected]> fix lint Signed-off-by: yisaer <[email protected]> fix lint Signed-off-by: yisaer <[email protected]> fix lint Signed-off-by: yisaer <[email protected]> revise handle error Signed-off-by: yisaer <[email protected]> revise handle error Signed-off-by: yisaer <[email protected]>
Yisaer
force-pushed
the
support_forward_replayer
branch
from
bc473df
to
29e164e
Compare
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
Signed-off-by: yisaer <[email protected]>
rebelice
approved these changes
Nov 1, 2021
qw4990
approved these changes
Nov 2, 2021
ti-chi-bot
added
status/LGT2
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 116501c
|
ti-chi-bot
added
the
status/can-merge
Yisaer
added
the
needs-cherry-pick-release-5.3
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 4, 2021
Signed-off-by: ti-srebot <[email protected]>
1 task
|
cherry pick to release-5.3 in PR #29436 |
|
/run-cherry-picker |
ti-chi-bot
pushed a commit
that referenced
this pull request
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #29495
Problem Summary:
Currently,
plan replayerdump api need the tidb-server which handle the request should be the same tidb-server which also receive the plan replayer statement. This will be hard to use in reality as most users exposes tidb status address behind the proxy (like kubernetes).This request makes plan replayer able to forward request if the both tidb-servers are not the same one.
What is changed and how it works?
Check List
Tests
I deploy a tidbcluster with 1pd/1kv/2db, I execute
plan replayerstatement to tidb-1, and try to get file from both tidb-1 and tidb-2, both requests are successful.Release note