Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle mixed offsets and names zones in CONVERT_TZ (#28528) #29311

Closed
wants to merge 2 commits into from
Closed

expression: handle mixed offsets and names zones in CONVERT_TZ (#28528) #29311

wants to merge 2 commits into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 1, 2021 •
edited
Loading

cherry-pick #28528 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29311

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/29311:release-5.2-465d2e7450f0
  • Support mixed named timezones and UTC offsets
  • Add support for +14:00
  • Support SYSTEM timezone

What problem does this PR solve?

This fixes the issues as reported in #8311

This fixes mixing named timezones like Europe/Moscow and UTC offsets like +01:00.

It also fixes support for the +14:00 timezone.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • Unit tests

Documentation

  • Affects user behaviors
  • Changes MySQL compatibility

Release note 

`CONVERT_TZ()` now supports mixing named timezones and UTC offsets

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • mjonss

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 1, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 1, 2021
Merged
4 tasks
@ti-srebot ti-srebot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.2-cherry-pick labels Nov 1, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 1, 2021
@ti-srebot
Copy link
Contributor Author

@dveeden you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2021
mjonss
mjonss approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2021
@kennytm
Copy link
Contributor

kennytm commented Feb 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c729aa6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@VelocityLight
Copy link

This pull request is closed because it's related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

You can find more details at:

@mjonss mjonss deleted the release-5.2-465d2e7450f0 branch September 22, 2022 13:56
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@kennytm kennytm kennytm approved these changes

Assignees

@dveeden dveeden

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @ti-chi-bot @kennytm @VelocityLight @mjonss @dveeden