Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: migrate test-infra to testify for http_handler_test.go #29374

Merged
merged 3 commits into from
Nov 4, 2021
Merged

server: migrate test-infra to testify for http_handler_test.go #29374

merged 3 commits into from
Nov 4, 2021

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Nov 3, 2021 •
edited
Loading

This closes #27804 .

Signed-off-by: tison [email protected]

Release note

None

/cc @morgo @disksing

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 3, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2021
@tisonkun
Copy link
Contributor Author

tisonkun commented Nov 4, 2021

/cc @xhebox @xiongjiwei

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 4, 2021
@xhebox
Copy link
Contributor

xhebox commented Nov 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4a280c9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 4, 2021
@ti-chi-bot
Copy link
Member

@tisonkun: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a696b43 into pingcap:master Nov 4, 2021
@tisonkun tisonkun deleted the issue-27804 branch November 4, 2021 10:37
@bb7133 bb7133 mentioned this pull request Dec 6, 2021
Closed
12 tasks
bb7133
bb7133 reviewed Dec 13, 2021
View reviewed changes
server/http_handler_test.go
ts.tidbdrv = NewTiDBDriver(ts.store)

cfg := newTestConfig()
cfg.Store = "tikv"
cfg.Port = 0
cfg.Status.StatusPort = 0
cfg.Status.ReportStatus = true
cfg.Socket = fmt.Sprintf("/tmp/%s.sock", t.Name())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason cfg.Socket is added in the server for tests? @tisonkun

I guess it caused #30642

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC it's for using different socket file when running parallel tests.

@bb7133 bb7133 mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 left review comments

@disksing disksing disksing approved these changes

@xhebox xhebox xhebox approved these changes

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for server/http_handler_test.go
5 participants
@tisonkun @ti-chi-bot @xhebox @bb7133 @disksing