Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl, executor: add warning log for lock/unlock tables (#29301) #29439

Merged
merged 3 commits into from
May 31, 2022
Merged

ddl, executor: add warning log for lock/unlock tables (#29301) #29439

merged 3 commits into from
May 31, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 4, 2021 •
edited
Loading

cherry-pick #29301 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29439

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/29439:release-5.1-dcbfda914ad0

What problem does this PR solve?

Issue Number: close #28967

Problem Summary: Add warning log for lock tables and unlock tables when enable-table-lock flag not enabled.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 4, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 4, 2021
Merged
4 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick labels Nov 4, 2021
@ti-srebot
Copy link
Contributor Author

@Defined2014 you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2021
@morgo
Copy link
Contributor

morgo commented Nov 12, 2021

/run-check_dev

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 16, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2022
@Defined2014
Copy link
Contributor

/run-all-tests

@Defined2014
Copy link
Contributor

/run-mysql-test

@Defined2014
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6097819

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2022
@Defined2014
Copy link
Contributor

/run-mysql-test tidb-test=pr/1661

@sre-bot
Copy link
Contributor

sre-bot commented May 31, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/60978197b868dbc8c38d0ad5f5a970e85e8276d2

@Defined2014
Copy link
Contributor

/run-mysql-test tidb-test=pr/1661

@ti-chi-bot ti-chi-bot merged commit ec172fe into pingcap:release-5.1 May 31, 2022
@Defined2014 Defined2014 deleted the release-5.1-dcbfda914ad0 branch May 31, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@morgo morgo morgo approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees

@Defined2014 Defined2014

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @morgo @Defined2014 @sre-bot @tangenta @zhouqiang-cl