dml : cache table reads data from the original table in a new transaction #29575
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
table/tables/cache_test.go
Outdated
| go func() { | ||
| tk2.MustExec("begin") | ||
| tk2.MustQuery("select *from complex_cache where id > 7").Check(testkit.Rows("9 109 1009")) | ||
| tk2.HasPlan("select *from complex_cache where id > 7", "UnionScan") |
There was a problem hiding this comment.
Loading cache is async, will it make the test unstable?
|
TestDropPrimaryKey is unstable test. |
|
/run-check_dev_2 |
| time.Sleep(100 * time.Millisecond) | ||
| if tk2.HasPlan("select *from complex_cache where id > 7", "UnionScan") { | ||
| break | ||
| } |
There was a problem hiding this comment.
Fail if still can't get the plan after several retries.
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: fd1d069
|
ti-chi-bot
added
the
status/can-merge
|
@jayl-zxl: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
this is a subTask of #25293
What is changed and how it works?
This question is mentioned in this pr #29444
The Cache table should reads data from the original table in a new transaction.
Change UpdateLockForRead(ctx sessionctx.Context, ts uint64) to UpdateLockForRead(store kv.Storage, ts uint64) to avoid misuse for sessionctx.Context that can cause data race.
Tests
Release note