-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: fix authentication with MySQL 5.1 and older clients (#29732) #29808
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/run-check_title |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2eeac32
|
/run-check_dev |
/merge |
/run-check_dev |
0d2214e
to
3025321
Compare
3025321
to
28e6d8d
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 28e6d8d
|
@bb7133: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-check_dev |
1 similar comment
/run-check_dev |
cherry-pick #29732 to release-5.3
What problem does this PR solve?
Issue Number: close #29725
Problem Summary:
handleAuthPlugin
checks for theClientPluginAuth
capability but this didn't set theAuthPlugin
causingreadOptionalSSLRequestAndHandshakeResponse
to return an error.Note that this allows authentication for users that use
mysql_native_password
to work, but users usingcaching_sha2_passwords
won't work.This does now return a more specific error in case authentication with
caching_sha2_password
is used.Check List
Tests
Verify the connection with MySQL client v5.1:
Side effects
Documentation
Release note