Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: let ignore columns be compatible with tidb backend (#27850) #30063

Open
wants to merge 5 commits into
base: release-5.2
Choose a base branch
from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 23, 2021

cherry-pick #27850 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30063

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/30063:release-5.2-c68791566d55

What problem does this PR solve?

Let lightning config mydumper.ignore-columns be compatible with tidb backend.

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Let the kv packend generated by encodeLoop contains the column names with ignore columns filtered instead of the raw column names.

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 23, 2021
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.2-cherry-pick labels Nov 23, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 23, 2021
@ti-srebot
Copy link
Contributor Author

@glorv you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 23, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 24, 2021
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

@@ -17,6 +17,7 @@ import (
"context"
"database/sql"
"fmt"
"github.com/stretchr/testify/require"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

????

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 24, 2021
@sleepymole
Copy link
Contributor

br/pkg/lightning/restore/restore_test.go:1517:9: assignment mismatch: 2 variables but mydump.NewCSVParser returns 1 values
br/pkg/lightning/restore/restore_test.go:1517:31: too many arguments in call to mydump.NewCSVParser

🤔

@sleepymole
Copy link
Contributor

/run-check_dev

@sleepymole
Copy link
Contributor

[2021-11-25T03:57:38.983Z] FAIL: restore_test.go:1445: chunkRestoreSuite.TestEncodeLoopIgnoreColumnsCSV
[2021-11-25T03:57:38.983Z] 
[2021-11-25T03:57:38.983Z] restore_test.go:1489:
[2021-11-25T03:57:38.983Z]     s.testEncodeLoopIgnoreColumnsCSV(c, cs.s, cs.ignoreColumns, cs.kvs, cs.header)
[2021-11-25T03:57:38.983Z] restore_test.go:1542:
[2021-11-25T03:57:38.983Z]     c.Assert(kvs[0].columns, DeepEquals, deliverKV.columns)
[2021-11-25T03:57:38.983Z] ... obtained []string = []string(nil)
[2021-11-25T03:57:38.983Z] ... expected []string = []string{"b", "c"}

@glorv
Copy link
Contributor

glorv commented Nov 30, 2021

/run-check_dev

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/lightning This issue is related to Lightning of TiDB. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants