Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executer: fix data race #30186

Merged
merged 7 commits into from
Nov 29, 2021
Merged

executer: fix data race #30186

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e13b088
executer: fix data race
hawkingrei Nov 26, 2021
a5c802a
Merge branch 'master' into executr_fix_data_race
ti-chi-bot Nov 29, 2021
3632336
Merge branch 'master' into executr_fix_data_race
ti-chi-bot Nov 29, 2021
c3cb07f
Merge branch 'master' into executr_fix_data_race
ti-chi-bot Nov 29, 2021
87309c2
Merge branch 'master' into executr_fix_data_race
ti-chi-bot Nov 29, 2021
2d69501
Merge branch 'master' into executr_fix_data_race
ti-chi-bot Nov 29, 2021
625f4ee
Merge branch 'master' into executr_fix_data_race
ti-chi-bot Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions executor/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4698,20 +4698,20 @@ func (b *executorBuilder) getCacheTable(tblInfo *model.TableInfo, startTS uint64
b.ctx.GetSessionVars().StmtCtx.ReadFromTableCache = true
return cacheData
}
go func() {
defer func() {
if r := recover(); r != nil {
logutil.BgLogger().Error("panic in the recoverable goroutine",
zap.Reflect("r", r),
zap.Stack("stack trace"))
}
}()
if !b.ctx.GetSessionVars().StmtCtx.InExplainStmt && !b.inDeleteStmt && !b.inUpdateStmt {
if !b.ctx.GetSessionVars().StmtCtx.InExplainStmt && !b.inDeleteStmt && !b.inUpdateStmt {
go func() {
defer func() {
if r := recover(); r != nil {
logutil.BgLogger().Error("panic in the recoverable goroutine",
zap.Reflect("r", r),
zap.Stack("stack trace"))
}
}()
err := tbl.(table.CachedTable).UpdateLockForRead(b.ctx.GetStore(), startTS)
if err != nil {
log.Warn("Update Lock Info Error")
}
}
}()
}()
}
return nil
}