Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: pushdown substring/char_length to tikv #30191

Merged
merged 17 commits into from
Dec 30, 2021
Merged

expression: pushdown substring/char_length to tikv #30191

merged 17 commits into from
Dec 30, 2021

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Nov 27, 2021 •
edited
Loading

Signed-off-by: guo-shaoge [email protected]

What problem does this PR solve?

Issue Number: close #31125 #30200

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

expression: pushdown substring/substr/mid/char_length to tikv

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-integration-copr-test tikv=pr/11494

@guo-shaoge
Merge branch 'master' of https://github.com/pingcap/tidb into pushdow…
b9409b3 
…n_substring

Signed-off-by: guo-shaoge <[email protected]>

Conflicts:
	expression/expression.go
@guo-shaoge
fix case
316c119 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2021
@guo-shaoge
fix case
86ef769 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@guo-shaoge
fix case
3f4bdd7 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

wjhuang2016
wjhuang2016 reviewed Nov 29, 2021
View reviewed changes
expression/expression.go Outdated
@@ -966,7 +966,7 @@ func scalarExprSupportedByTiKV(sf *ScalarFunction) bool {

// string functions.
ast.Length, ast.BitLength, ast.Concat, ast.ConcatWS /*ast.Locate,*/, ast.Replace, ast.ASCII, ast.Hex,
ast.Reverse, ast.LTrim, ast.RTrim /*ast.Left,*/, ast.Strcmp, ast.Space, ast.Elt, ast.Field,
ast.Reverse, ast.LTrim, ast.RTrim /*ast.Left,*/, ast.Strcmp, ast.Space, ast.Elt, ast.Field, ast.Substring,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about MID() and SubStr() ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@guo-shaoge
Copy link
Collaborator Author

Related tikv pr: tikv/tikv#11494

@guo-shaoge
fix comment
550e22e 
fixSigned-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 29, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2021
guo-shaoge
guo-shaoge commented Dec 29, 2021
View reviewed changes
expression/integration_test.go
@@ -3472,36 +3472,36 @@ func TestExprPushdown(t *testing.T) {
"(4,'511111','611',7,8,9),(5,'611111','711',8,9,10)")

// case 1, index scan without double read, some filters can not be pushed to cop task
rows := tk.MustQuery("explain format = 'brief' select col2, col1 from t use index(key1) where col2 like '5%' and substr(col1, 1, 1) = '4'").Rows()
rows := tk.MustQuery("explain format = 'brief' select col2, col1 from t use index(key1) where col2 like '5%' and from_base64(to_base64(substr(col1, 1, 1))) = '4'").Rows()
require.Equal(t, "root", fmt.Sprintf("%v", rows[1][2]))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from_base64 and to_base64 has no plan to pushdown for now...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks so dirty...

@guo-shaoge guo-shaoge changed the title expression: pushdown substring to tikv expression: pushdown substring/char_length to tikv Dec 29, 2021
@guo-shaoge
fix fmt
0a51af1 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@guo-shaoge
Copy link
Collaborator Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Dec 29, 2021 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/57107673fb2ae57f791f85f8c09c974564b3c5fb

@guo-shaoge
Copy link
Collaborator Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 30, 2021
@wshwsh12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 43203b7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2021
@guo-shaoge
Copy link
Collaborator Author

/run-unit-test

1 similar comment
@guo-shaoge
Copy link
Collaborator Author

/run-unit-test

@ti-chi-bot
Copy link
Member

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Collaborator Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 7f85091 into pingcap:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@ichn-hu ichn-hu ichn-hu approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pushdown substring/substr/mid/char_length to TiKV
6 participants
@guo-shaoge @ti-chi-bot @sre-bot @wshwsh12 @wjhuang2016 @ichn-hu