Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: avoid sum from avg overflow (#30010) #30378

Merged
merged 8 commits into from
Sep 19, 2022
Merged

executor: avoid sum from avg overflow (#30010) #30378

merged 8 commits into from
Sep 19, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 3, 2021 •
edited
Loading

cherry-pick #30010 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30378

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/30378:release-5.2-9aa756336e7b

What problem does this PR solve?

Issue Number: close #29952

Problem Summary:

  1. the sum from avg may overflow, we should infer the type as the normal sum.
  2. the previous PR expression, planner: fix decimal results for aggregate functions #20017 is a hack to fix the issue , we should let the final agg output the target return type which is inferred in TypeInfe() for Agg.
  3. typeInfer4xxx should valid the precision and scale of decimal type.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 3, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 3, 2021
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.2-cherry-pick labels Dec 3, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 3, 2021
Merged
12 tasks
@ti-srebot ti-srebot added this to the v5.2.2 milestone Dec 3, 2021
@ti-chi-bot ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 3, 2021
@ti-srebot
Copy link
Contributor Author

@fzhedu you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 3, 2021
hawkingrei
hawkingrei reviewed Dec 3, 2021
View reviewed changes
executor/aggfuncs/builder.go Outdated
"github.com/cznic/mathutil"
"github.com/pingcap/parser/ast"
"github.com/pingcap/parser/mysql"
=======
>>>>>>> 9aa756336... executor: avoid sum from avg overflow (#30010)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@fzhedu fzhedu requested a review from hawkingrei January 4, 2022 06:00
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 4, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jan 5, 2022

/run-check_dev

@fzhedu
Copy link
Contributor

fzhedu commented Jan 6, 2022

/run-mysql-test

@fzhedu
Copy link
Contributor

fzhedu commented Jan 7, 2022

/run-mysql-test

2 similar comments
@fzhedu
Copy link
Contributor

fzhedu commented Jan 7, 2022

/run-mysql-test

@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/run-mysql-test

windtalker
windtalker approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 7, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jan 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 48fd09a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 7, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Jan 7, 2022

/run-mysql-test

6 similar comments
@hawkingrei
Copy link
Member

/run-mysql-test

@purelind
Copy link
Contributor

purelind commented Jan 7, 2022

/run-mysql-test

@purelind
Copy link
Contributor

purelind commented Jan 7, 2022

/run-mysql-test

@purelind
Copy link
Contributor

purelind commented Jan 7, 2022

/run-mysql-test

@fzhedu
Copy link
Contributor

fzhedu commented Jan 7, 2022

/run-mysql-test

@fzhedu
Copy link
Contributor

fzhedu commented Jan 10, 2022

/run-mysql-test

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 19, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2022
@LittleFall
Copy link
Contributor

/rebuild

@LittleFall
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@LittleFall
Copy link
Contributor

/rebuild

@ti-chi-bot ti-chi-bot merged commit 1582c54 into pingcap:release-5.2 Sep 19, 2022
@LittleFall LittleFall deleted the release-5.2-9aa756336e7b branch September 19, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhedu fzhedu fzhedu left review comments

@LittleFall LittleFall LittleFall approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@windtalker windtalker windtalker approved these changes

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@winoros winoros Awaiting requested review from winoros

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees

@fzhedu fzhedu

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @fzhedu @hawkingrei @purelind @LittleFall @windtalker @VelocityLight