Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor/split_test.go: migrate test-infra to testify #30485

Merged
merged 18 commits into from
Dec 29, 2021
Merged

executor/split_test.go: migrate test-infra to testify #30485

merged 18 commits into from
Dec 29, 2021

Conversation

zach030
Copy link
Contributor

@zach030 zach030 commented Dec 7, 2021

What problem does this PR solve?

Issue Number: close #28617

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2021
tangenta
tangenta reviewed Dec 10, 2021
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make these tests run in parallel by adding t.Parallel()?

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2021
@zach030
Copy link
Contributor Author

zach030 commented Dec 10, 2021

Ok! I will add it.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2021
tangenta
tangenta reviewed Dec 11, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member

#30267

There is an example of migration.

hawkingrei
hawkingrei reviewed Dec 11, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
executor/split_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2021
hawkingrei
hawkingrei reviewed Dec 11, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
executor/split_test.go Outdated Show resolved Hide resolved
executor/split_test.go Outdated Show resolved Hide resolved
executor/split_test.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member

After fixed, Please @me or join in tidb slack channel to find me.

@zach030
Copy link
Contributor Author

zach030 commented Dec 11, 2021

After fixed, Please @me or join in tidb slack channel to find me.

Thx, I have fixed it.

tangenta
tangenta reviewed Dec 13, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
@hawkingrei
Copy link
Member

Please run make fmt in the project root directory to fix linter.

hawkingrei
hawkingrei reviewed Dec 13, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
@zach030
Copy link
Contributor Author

zach030 commented Dec 13, 2021

Please run make fmt in the project root directory to fix linter.

Thanks! please review again

hawkingrei
hawkingrei reviewed Dec 13, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Dec 23, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Dec 23, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
tangenta
tangenta reviewed Dec 23, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor

@zach030 Here are some backgrounds about the CI tests. It explains why we move to the serial way, FYI.

@zach030
Copy link
Contributor Author

zach030 commented Dec 24, 2021

already done

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 25, 2021
@ti-chi-bot
Copy link
Member

@zach030: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

hawkingrei
hawkingrei reviewed Dec 25, 2021
View reviewed changes
executor/split_test.go Outdated Show resolved Hide resolved
executor/split_test.go Outdated
c.Assert(err, IsNil)
c.Assert(len(valueList), Equals, e.num+1)
require.NoError(t, err)
require.Len(t, len(valueList), e.num+1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@hawkingrei hawkingrei self-requested a review December 25, 2021 14:01
@sre-bot
Copy link
Contributor

sre-bot commented Dec 25, 2021 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/4f2b90627d28ac1e1a25143312c8d39daec91e57

@zach030
Copy link
Contributor Author

zach030 commented Dec 28, 2021

@hawkingrei can we merge now

@tiancaiamao
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d440900

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 29, 2021
@ti-chi-bot
Copy link
Member

@zach030: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 8193c46 into pingcap:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for split_test.go
6 participants
@zach030 @ti-chi-bot @hawkingrei @tangenta @sre-bot @tiancaiamao