Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor,util: write slow query to slow log no matter what log level (#30461) #30493

Merged
merged 5 commits into from
Feb 22, 2022
Merged

executor,util: write slow query to slow log no matter what log level (#30461) #30493

merged 5 commits into from
Feb 22, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Dec 7, 2021 •
edited
Loading

cherry-pick #30461 to release-5.3
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30493

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/30493:release-5.3-d83ee8cfdad4

What problem does this PR solve?

Issue Number: close #30309

Problem Summary:

What is changed and how it works?

The slow log uses the default log level that is info level.
Executor writes slow query by log.WARN methods

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 7, 2021
@ti-srebot ti-srebot mentioned this pull request Dec 7, 2021
Merged
10 tasks
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.3-cherry-pick labels Dec 7, 2021
@ti-srebot
Copy link
Contributor Author

@TonsnakeLin please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 8, 2021
@guo-shaoge
Copy link
Collaborator

/run-mysql-test

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 15, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/run-check_dev

1 similar comment
@guo-shaoge
Copy link
Collaborator

/run-check_dev

@TonsnakeLin
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@TonsnakeLin: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@youjiali1995
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 78dc9b6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 21, 2022
@guo-shaoge
Copy link
Collaborator

/run-check_dev
/run-mysql-test

@TonsnakeLin
Copy link
Contributor

/run-mysql-test

1 similar comment
@TonsnakeLin
Copy link
Contributor

/run-mysql-test

@TonsnakeLin
Copy link
Contributor

/run-check_dev

1 similar comment
@youjiali1995
Copy link
Contributor

/run-check_dev

@youjiali1995
Copy link
Contributor

/run-mysql-test

1 similar comment
@TonsnakeLin
Copy link
Contributor

/run-mysql-test

@guo-shaoge
Copy link
Collaborator

/run-mysql-test
/run-check_dev

@guo-shaoge
Copy link
Collaborator

/run-check_dev

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TonsnakeLin
Copy link
Contributor

/run-check_dev

@ti-chi-bot ti-chi-bot merged commit 7296088 into pingcap:release-5.3 Feb 22, 2022
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@breezewish breezewish Awaiting requested review from breezewish

@djshow832 djshow832 Awaiting requested review from djshow832

@SabaPing SabaPing Awaiting requested review from SabaPing

Assignees

@TonsnakeLin TonsnakeLin

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.3-cherry-pick
Projects
None yet
Milestone
v5.3.1
Development

Successfully merging this pull request may close these issues.
9 participants
@ti-srebot @ti-chi-bot @guo-shaoge @hawkingrei @TonsnakeLin @youjiali1995 @xhebox @purelind @zhouqiang-cl