Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Introduce a new global variable to control the historical statistics feature #30646

Merged
merged 7 commits into from
Dec 14, 2021
Merged

planner: Introduce a new global variable to control the historical statistics feature #30646

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
34a3092
planner: Introduce a new global variable to control the historical st…
An-DJ Dec 12, 2021
de5601b
planner: add unit test of tidb_enable_historical_stats
An-DJ Dec 13, 2021
b0175b5
Merge branch 'master' into historical-stats-switch
An-DJ Dec 13, 2021
cc81d16
Merge branch 'master' into historical-stats-switch
An-DJ Dec 13, 2021
7cb95ad
Merge branch 'master' into historical-stats-switch
qw4990 Dec 14, 2021
901ff27
Merge branch 'master' into historical-stats-switch
ti-chi-bot Dec 14, 2021
6aba526
Merge branch 'master' into historical-stats-switch
ti-chi-bot Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions executor/set_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,12 @@ func (s *testSerialSuite1) TestSetVar(c *C) {
tk.MustExec("set global tidb_enable_tso_follower_proxy = 0")
tk.MustQuery("select @@tidb_enable_tso_follower_proxy").Check(testkit.Rows("0"))
c.Assert(tk.ExecToErr("set tidb_enable_tso_follower_proxy = 1"), NotNil)

tk.MustQuery("select @@tidb_enable_historical_stats").Check(testkit.Rows("0"))
tk.MustExec("set global tidb_enable_historical_stats = 1")
tk.MustQuery("select @@tidb_enable_historical_stats").Check(testkit.Rows("1"))
tk.MustExec("set global tidb_enable_historical_stats = 0")
tk.MustQuery("select @@tidb_enable_historical_stats").Check(testkit.Rows("0"))
}

func (s *testSuite5) TestTruncateIncorrectIntSessionVar(c *C) {
Expand Down
6 changes: 5 additions & 1 deletion sessionctx/variable/sysvar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,7 +1205,11 @@ var defaultSysVars = []*SysVar{
{Scope: ScopeSession, Name: PluginDir, Value: "/data/deploy/plugin", GetSession: func(s *SessionVars) (string, error) {
return config.GetGlobalConfig().Plugin.Dir, nil
}},

{Scope: ScopeGlobal, Name: TiDBEnableHistoricalStats, Value: Off, Type: TypeBool, GetGlobal: func(s *SessionVars) (string, error) {
return getTiDBTableValue(s, "tidb_enable_historical_stats", Off)
}, SetGlobal: func(s *SessionVars, val string) error {
return setTiDBTableValue(s, "tidb_enable_historical_stats", val, "Current historical statistics enable status")
}},
/* tikv gc metrics */
{Scope: ScopeGlobal, Name: TiDBGCEnable, Value: On, Type: TypeBool, GetGlobal: func(s *SessionVars) (string, error) {
return getTiDBTableValue(s, "tikv_gc_enable", On)
Expand Down
2 changes: 2 additions & 0 deletions sessionctx/variable/tidb_vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,8 @@ const (
TiDBGCScanLockMode = "tidb_gc_scan_lock_mode"
// TiDBEnableEnhancedSecurity restricts SUPER users from certain operations.
TiDBEnableEnhancedSecurity = "tidb_enable_enhanced_security"
// TiDBEnableHistoricalStats enables the historical statistics feature (default off)
TiDBEnableHistoricalStats = "tidb_enable_historical_stats"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests for it. You can add them here set_test.go#L43 .

)

// TiDB intentional limits
Expand Down