testify: migrate test-infra to testify for distsql_test.go #28574 #30654

znhh6018 · 2021-12-12T11:43:02Z

What problem does this PR solve?

Issue Number: close #28574

Problem Summary:

What is changed and how it works?

Check List

Release note

None

ti-chi-bot · 2021-12-12T11:43:04Z

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

znhh6018 · 2021-12-12T11:44:59Z

/cc @hawkingrei @tisonkun

executor/distsql_test.go

znhh6018 · 2021-12-12T11:59:32Z

if I don't remove "unlint:unsed" on checkGoroutineExists, goword fail.
After I removed "unlint:unsed" and commit , the check_dev fail....

hawkingrei · 2021-12-12T14:50:28Z

executor/distsql_test.go

 )

-// nolint:unused
 func checkGoroutineExists(keyword string) bool {


it can remove because no one uses it.

you mean removing the checkGoroutineExists function ?

Yes.

[2021-12-12T12:11:56.974Z] executor/distsql_test.go:43:6: func `checkGoroutineExists` is unused (unused) [2021-12-12T12:11:56.974Z] func checkGoroutineExists(keyword string) bool { [2021-12-12T12:11:56.974Z] ^

I found checkGoroutineExists is called in line 123...

I know.

tidb/executor/seqtest/seq_executor_serial_test.go

Line 750 in 9cd0b49

func checkGoroutineExists(keyword string) bool {

there is the same function.

Try to delete executor/distsql_test.go:43:6 checkGoroutineExists or checkGoroutineExists in tidb/executor/seqtest/seq_executor_serial_test.go?

make checkGoroutineExists public and delete the redundant.

okay , let me try

package name executor_test can be replaced by executor.

I did as follows，
1.make checkGoroutineExists public in tidb/executor/seqtest/seq_executor_serial_test.go
2.package name executor_test replaced by executor in tidb/executor/seqtest/seq_executor_serial_test.go
3.remove checkGoroutineExists in executor/distsql_test.go , use executor.CheckGoroutineExists instead, it prompted CheckGoroutineExists not declared by executor
how could I solve this...

hawkingrei · 2021-12-12T15:13:22Z

/run-check_dev

hawkingrei · 2021-12-13T06:22:20Z

/run-all-tests

…pingcap#30514)

…go (pingcap#30525)

…character set (pingcap#30537)

…pear on Other components (TiKV) TopN records (pingcap#27050)

…0640)

…distsql_test

…ap#30550)

…ifer start with '$' (pingcap#29750)

… correctly (pingcap#30951) close pingcap#30950

…ingcap#30889) close pingcap#30720

…30916)

…0805)

close pingcap#30658

…cap#30952) close pingcap#28635

…gcap#30966) close pingcap#30965

…elemetry and types (pingcap#30874)

…cap#30981) close pingcap#30971

ref pingcap#29661

Signed-off-by: yisaer <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>

close pingcap#30578

hawkingrei · 2021-12-25T09:51:07Z

executor/distsql_test.go

-func (s *testSuite3) TestIndexLookUpGetResultChunk(c *C) {
-	tk := testkit.NewTestKit(c, s.store)
+func TestIndexLookUpGetResultChunk(t *testing.T) {
+	t.Parallel()


t.Parallel() need to be removed. it is a decision that we have made recently.

sorry , not familiar with some git operations , things seemed went bad , just close and create a new PR............

… and collect histogram-needed columns (pingcap#30671)

and add comment to avoid goword check fail

sre-bot · 2021-12-25T14:50:18Z

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/dc8c2bfda02e7e0374c7dfb84daf1ca5b23af995

migrate test-infra to testify for distsql_test.go pingcap#28574

ba2121e

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 12, 2021

ti-chi-bot requested review from hawkingrei and tisonkun December 12, 2021 11:44

hawkingrei reviewed Dec 12, 2021

View reviewed changes

executor/distsql_test.go Outdated Show resolved Hide resolved

optimize dom

74a6f18

hawkingrei reviewed Dec 12, 2021

View reviewed changes

Merge branch 'master' into fix_distsql_test

affd3c7

Yisaer and others added 16 commits December 13, 2021 16:10

planner: add trace for join eliminate rule (pingcap#30343)

6495a5a

executor: migrate test-infra to testify for executor/shuffle_test.go (…

9a64217

…pingcap#30514)

planner: make (*AccessPath).OnlyPointRange more succinct (pingcap#30520)

b8dcc09

planner: add trace for join reorder (pingcap#30394)

a532973

executor: migrate test-infra to testify for executor/union_scan_test.…

d3833c2

…go (pingcap#30525)

expression: make cast return error if cast binary literal to another …

e8577c7

…character set (pingcap#30537)

*: update tikv client (pingcap#30670)

68118f1

*: update sysutil in go.mod to fix panic when search log (pingcap#30523)

d8a48d9

topsql: shouldn't evict the SQL meta, since the evicted SQL can be ap…

12e2288

…pear on Other components (TiKV) TopN records (pingcap#27050)

testify: migrate test-infra to testify for analyze_test.go (pingcap#3…

b876788

…0640)

fix CheckGoroutineExists,still bugs

5494d06

Merge branch 'fix_distsql_test' of github.com:znhh6018/tidb into fix_…

8475adf

…distsql_test

util: replace compareDatum by compare, point part (pingcap#30575)

b626745

test: make all the tests run in serial (pingcap#30692)

b4df7ca

statistics: add mutex for Handle.globalMap and Handle.feedback (pingc…

ac25e9f

…ap#30550)

executor: fix regular expression in json so that it could match ident…

a8ad203

…ifer start with '$' (pingcap#29750)

tiancaiamao and others added 16 commits December 23, 2021 14:45

executor: display 'show create table' and INFOSCHEMA for cached table…

d2ed2ae

… correctly (pingcap#30951) close pingcap#30950

br: extend the timeout for scan region since 3 seconds is not enough (p…

693946b

…ingcap#30889) close pingcap#30720

planner: remove bindSQL from planCacheKey to planCacheValue (pingcap#…

0d899cd

…30916)

execution: refine precision of cast as decimal in agg func (pingcap#3…

df58e6c

…0805)

*: fix data race in the tikv_client (pingcap#30964)

dfaabf4

close pingcap#30658

ddl: migrate test-infra to testify for ddl/db_partition_test.go (ping…

586eed9

…cap#30952) close pingcap#28635

planner: fix AccessPath.TableFilters got modified unexpectedly (pin…

e24493f

…gcap#30966) close pingcap#30965

test: merge serial tests in ddl, infoschema, session, store, table, t…

4dc385c

…elemetry and types (pingcap#30874)

executor: fix the returned field count of the prepare statement (ping…

404895c

…cap#30981) close pingcap#30971

binlog: allow multiple ddl targets (pingcap#30904)

6e6db1f

planner: trace predicate push down (pingcap#30902)

30c5f5b

ref pingcap#29661

placement: give default 2 followers for non-sugar syntax (pingcap#31000)

93d28b9

flatten the json output (pingcap#30905)

42cf333

Signed-off-by: yisaer <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>

test: control log level with environment variables (pingcap#30871)

3de1384

planner: add usage of paging copr in optimizer (pingcap#30536)

ab821eb

close pingcap#30578

test: merge serial tests in cmd, planner, server, util (pingcap#31003)

9ad0096

hawkingrei reviewed Dec 25, 2021

View reviewed changes

xuyifangreeneyes and others added 6 commits December 25, 2021 18:21

planner: change predicateColumnCollector to columnStatsUsageCollector…

76aae0d

… and collect histogram-needed columns (pingcap#30671)

migrate test-infra to testify for distsql_test.go pingcap#28574

c57e629

optimize dom

a0702b2

fix CheckGoroutineExists,still bugs

7ee2583

remove t.parallel() at distsql_test.go:line 373,revert to origin state

fbf67aa

and add comment to avoid goword check fail

a

dc8c2bf

znhh6018 requested a review from a team as a code owner December 25, 2021 14:37

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 25, 2021

znhh6018 closed this Dec 25, 2021

znhh6018 deleted the fix_distsql_test branch December 25, 2021 14:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

testify: migrate test-infra to testify for distsql_test.go #28574 #30654

testify: migrate test-infra to testify for distsql_test.go #28574 #30654

znhh6018 commented Dec 12, 2021

ti-chi-bot commented Dec 12, 2021

znhh6018 commented Dec 12, 2021

znhh6018 commented Dec 12, 2021

hawkingrei Dec 12, 2021

znhh6018 Dec 12, 2021

hawkingrei Dec 12, 2021

znhh6018 Dec 12, 2021

hawkingrei Dec 12, 2021

hawkingrei Dec 13, 2021 •

edited

Loading

hawkingrei Dec 13, 2021

znhh6018 Dec 13, 2021

hawkingrei Dec 13, 2021

znhh6018 Dec 13, 2021

hawkingrei commented Dec 12, 2021

hawkingrei commented Dec 13, 2021

hawkingrei Dec 25, 2021

znhh6018 Dec 25, 2021

sre-bot commented Dec 25, 2021

testify: migrate test-infra to testify for distsql_test.go #28574 #30654

testify: migrate test-infra to testify for distsql_test.go #28574 #30654

Conversation

znhh6018 commented Dec 12, 2021

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Dec 12, 2021

znhh6018 commented Dec 12, 2021

znhh6018 commented Dec 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hawkingrei Dec 13, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hawkingrei commented Dec 12, 2021

hawkingrei commented Dec 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sre-bot commented Dec 25, 2021

hawkingrei Dec 13, 2021 •

edited

Loading