Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: avoid setting ratelimit action in tracker when disabled #31110

Merged
merged 35 commits into from
Mar 29, 2022
Merged

store: avoid setting ratelimit action in tracker when disabled #31110

merged 35 commits into from
Mar 29, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Dec 29, 2021 •
edited
Loading

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

When tidb_enable_rate_limit_action is disabled, ratelimit action will still be set in memory tracker which would consume unnecessary performance

Issue Number: ref #30353

Problem Summary:

What is changed and how it works?

avoid setting ratelimit action in tracker when disabled

Check List

Tests

  • Unit test

Release note

None

@Yisaer
skip setting
883ceda 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 29, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 29, 2021
@Yisaer
skip setting
a58a938 
Signed-off-by: yisaer <[email protected]>
ichn-hu
ichn-hu requested changes Jan 4, 2022
View reviewed changes
executor/aggregate.go Outdated Show resolved Hide resolved
session/session_test.go Outdated Show resolved Hide resolved
wshwsh12
wshwsh12 reviewed Jan 11, 2022
View reviewed changes
util/memory/action.go Outdated Show resolved Hide resolved
@Yisaer
address the comment
dcc7d72 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2022
wshwsh12
wshwsh12 approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2022
@Yisaer Yisaer requested a review from ichn-hu March 25, 2022 09:24
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 25, 2022

/merge

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 28, 2022

/run-unit-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 28, 2022

/merge

@ti-chi-bot ti-chi-bot merged commit 09edaee into pingcap:master Mar 29, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Yisaer @ti-srebot
cherry pick pingcap#31110 to release-5.0
4b1a3dc 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33526

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Yisaer @ti-srebot
cherry pick pingcap#31110 to release-5.1
d6e10c1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33528

@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 failed

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Yisaer @ti-srebot
cherry pick pingcap#31110 to release-5.3
1824248 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33529

@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
1 task
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Yisaer @ti-srebot
cherry pick pingcap#31110 to release-5.4
2e9e895 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33530

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 29, 2022
@Yisaer @ti-srebot
cherry pick pingcap#31110 to release-6.0
a6dcfeb 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 29, 2022
Closed
1 task
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #33531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichn-hu ichn-hu ichn-hu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@JmPotato JmPotato JmPotato approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Yisaer @ti-chi-bot @sre-bot @hawkingrei @ti-srebot @JmPotato @wshwsh12 @ichn-hu