-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lightning: support both gs and gcs in url (#30254) #31168
base: release-5.2
Are you sure you want to change the base?
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@glorv you're already a collaborator in bot's repo. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 55f4861
|
cherry-pick #30254 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/31168
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
Lightning will result in error if the storage url is "gs://xxx" instead of "gcs://xxx" but the original storage package support both of them, lightning pre-check should be compitible with both.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note