Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add a test for cached table #31191

Merged
merged 9 commits into from
Aug 12, 2022
Merged

br: add a test for cached table #31191

merged 9 commits into from
Aug 12, 2022

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #31190

Problem Summary:

Handle the compatibility for the cached table feature with br

What is changed and how it works?

TableCacheStatus attribute of table info is ignored, so a cached table is handled as a normal table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 30, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2021
@tiancaiamao
Copy link
Contributor Author

A subtask for #25293

@sre-bot
Copy link
Contributor

sre-bot commented Dec 30, 2021 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2cd1f0cb1794814565ebae0e906e58833ab6d154

@3pointer
Copy link
Contributor

/run-integration-br-tests

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/run-integration-br-tests

@tiancaiamao tiancaiamao mentioned this pull request Jan 4, 2022
Closed
32 tasks
@tiancaiamao
Copy link
Contributor Author

/rebuild

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2022
@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@tiancaiamao
Copy link
Contributor Author

/run-integration-br-tests

@3pointer
Copy link
Contributor 

[2022-03-22T10:10:50.943Z] + run_sql 'select create_options from information_schema.tables where table_schema = br_cache_table and table_name = '\''cache_1'\'';'

[2022-03-22T10:10:50.943Z] ERROR 1054 (42S22) at line 1: Unknown column 'br_cache_table' in 'where clause'

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2022
@xhebox
Copy link
Contributor

xhebox commented Aug 12, 2022

/run-integration-br-tests

@xhebox
Copy link
Contributor

xhebox commented Aug 12, 2022

/run-integration-br-tests

@xhebox
Copy link
Contributor

xhebox commented Aug 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2cd1f0c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2022
@ti-chi-bot ti-chi-bot merged commit 7ca3686 into pingcap:master Aug 12, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Aug 12, 2022
@tiancaiamao @ti-srebot
cherry pick pingcap#31191 to release-6.0
398cd03 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Aug 12, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-6.0 in PR #37075

@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 20 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 9 min 7 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 10 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 57 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tiancaiamao tiancaiamao deleted the br-cache-table branch October 11, 2022 06:24
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 6.2: error checking out 6.2: exit status 1. output: error: pathspec '6.2' did not match any file(s) known to git

@tiancaiamao tiancaiamao added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed needs-cherry-pick-6.2 labels Oct 11, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 6.1: error checking out 6.1: exit status 1. output: error: pathspec '6.1' did not match any file(s) known to git

@tiancaiamao
Copy link
Contributor Author

/run-cherry-picker

1 similar comment
@YangKeao
Copy link
Member

/run-cherry-picker

@YangKeao YangKeao added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Jun 26, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #44943.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 26, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 29, 2023
@ti-chi-bot
br: add a test for cached table (#31191) (#44943)
2a463d7 
close #31190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3pointer 3pointer 3pointer left review comments

@xhebox xhebox xhebox approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. severity/moderate size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore the TableCacheStatus table info in br, so it's handled as a normal table
8 participants
@tiancaiamao @ti-chi-bot @sre-bot @3pointer @xhebox @ti-srebot @YangKeao @lcwangchao