tools: exit(1) when test/build fail

[hawkingrei]

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Issue Number: ref #30822

Problem Summary:

What is changed and how it works?

It is friendly for CI to exit(1) when test/build fail.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• tangenta
• tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/384220c207f747e94caeea894e3d25116064e319

[tiancaiamao]

Why not just

func main() {
     err := doSth()
     if err != nil {
        os.Exit(-1)
     }
}

[hawkingrei]

Why not just

func main() {
     err := doSth()
     if err != nil {
        os.Exit(-1)
     }
}

It is friendly that we can check the status when all the tasks finish running. Especially when they run concurrently.

[hawkingrei]

We also can create an error to return.

[hawkingrei]

/run-check_dev_2

[tiancaiamao]

1. It's unnecessary to introduce a external atomic package for such simple changes.
2. If you want to exit immediately after the first error, just os.Exit(), otherwise if you want to collect all the exit info, you can add a field in worker struct, here is type numa struct {exitErr error ...}

[tiancaiamao]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 69fe2e0

[ti-chi-bot]

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[hawkingrei]

/run-check_dev_2

[hawkingrei]

/run-check_dev

[hawkingrei]

/run-mysql-test

[hawkingrei]

/run-mysql-test

[hawkingrei]

/run-check_dev_2